Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into releases/v2 #1212

Merged
merged 27 commits into from
Aug 25, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 25, 2022

Merging 21bf308 into releases/v2

Conductor for this PR is @edoardopirovano

Contains the following pull requests:

Please review the following:

  • The CHANGELOG displays the correct version and date.
  • The CHANGELOG includes all relevant, user-facing changes since the last release.
  • There are no unexpected commits being merged into the releases/v2 branch.
  • The docs team is aware of any documentation changes that need to be released.
  • The mergeback PR is merged back into main after this PR is merged.
  • The v1 release PR is merged after this PR is merged.

aeisenberg and others added 27 commits August 15, 2022 07:56
When someone creates an invalid `queries` entry in the codeql config
file, like this:

```
queries:
  - foo.ql
```

THe error message is confusing, looking like this:

```
  Error: Cannot use 'in' operator to search for 'uses' in ql/ql/src
  TypeError: Cannot use 'in' operator to search for 'uses' in ql/ql/src
      at loadConfig (/home/runner/work/_actions/github/codeql-action/71a8b35ff4c80fcfcd05bc1cd932fe3c08f943ca/lib/config-utils.js:577:41)
```

With this change, the error message is more comprehensible:

`queries must be an array, with each entry having a 'uses' property`
This is no longer needed since `long` now includes its own types.
Mergeback v2.1.20 refs/heads/releases/v2 into main
TRAP Caching: Unset missing cache rather than setting to `undefined`
Handle other cases where the config is invalid.
Co-authored-by: Henry Mercer <henrymercer@github.com>
More readable error message for invalid `queries` block and invalid `query-filters` blocl
These were supplying CODEQL_EXTRACTOR_GO_BUILD_TRACING=true rather than
CODEQL_EXTRACTOR_GO_BUILD_TRACING=on,
therefore tracing wasn't being tested.
This is currently broken in CLI versions 2.10.3 and earlier.
It is enough to pass the checks now that we only use the runner for PR
checks.
…edule

When running on a schedule, make a better guess about whether we're analyzing the default branch.
@edoardopirovano edoardopirovano marked this pull request as ready for review August 25, 2022 12:17
@edoardopirovano edoardopirovano requested a review from a team as a code owner August 25, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants