Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAP Caching: Unset missing cache rather than setting to undefined #1207

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

edoardopirovano
Copy link
Contributor

In other parts of the code, we expect the values in the map to not be undefined, so we are getting warnings like https://github.com/github/vscode-codeql/actions/runs/2911692423 if we fail to find a cache in the Actions cache because we are setting a value of undefined here. Let's just remove the language from the map entirely if we don't have a cache for it.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner August 23, 2022 14:41
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When we set the property undefined, it still appears in Object.values(...). Deleting it removes it from Object.values(...), so we don't attempt to find its size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants