Skip to content

Commit

Permalink
Remove deprecated CODEQL_PASS_CONFIG_TO_CLI env var from PR checks
Browse files Browse the repository at this point in the history
  • Loading branch information
henrymercer committed Jan 4, 2024
1 parent 67be7bc commit d7437a2
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 22 deletions.
1 change: 0 additions & 1 deletion .github/workflows/__config-export.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions .github/workflows/codescanning-config-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
name: Code-Scanning config CLI tests
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CODEQL_PASS_CONFIG_TO_CLI: true

on:
push:
Expand Down Expand Up @@ -204,15 +203,3 @@ jobs:
packs: + codeql/javascript-queries
config-file-test: .github/codeql/other-config-properties.yml
tools: ${{ steps.prepare-test.outputs.tools-url }}

- name: Config not generated when env var is not set
if: success() || failure()
env:
CODEQL_PASS_CONFIG_TO_CLI: false
uses: ./../action/.github/actions/check-codescanning-config
with:
expected-config-file-contents: ""
languages: javascript
packs: + codeql/javascript-queries
config-file-test: .github/codeql/other-config-properties.yml
tools: ${{ steps.prepare-test.outputs.tools-url }}
2 changes: 0 additions & 2 deletions pr-checks/checks/config-export.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: "Config export"
description: "Tests that the code scanning configuration file is exported to SARIF correctly."
versions: ["latest", "nightly-latest"]
env:
CODEQL_PASS_CONFIG_TO_CLI: true
steps:
- uses: ./../action/init
with:
Expand Down
4 changes: 0 additions & 4 deletions pr-checks/checks/packaging-codescanning-config-inputs-js.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: "Packaging: Config and input passed to the CLI"
description: "Checks that specifying packages using a combination of a config file and input to the Action works"
versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with old CLIs

env:
CODEQL_PASS_CONFIG_TO_CLI: true

steps:
- uses: ./../action/init
with:
Expand Down

0 comments on commit d7437a2

Please sign in to comment.