Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize nomenclature: marker row vs. delimiter row #273

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Normalize nomenclature: marker row vs. delimiter row #273

merged 1 commit into from
Jul 20, 2023

Conversation

waldyrious
Copy link

The code for the table extension used the term "marker row" for the line separating a table header from the body, but the spec calls it "delimiter row". This change normalizes the terminology in the code so that it's consistent with the spec.

This PR addresses issue #269.

The code for the table extension used the term 'marker row',
but the spec calls it 'delimiter row'.

This change normalizes the terminology so that it's consistent.
@waldyrious
Copy link
Author

Note: some of the changes the original commit f8dd3e0 conflicted with some of the changes from 78e3f1d. I have now updated the branch to resolve the conflict.

@waldyrious
Copy link
Author

As I've been seeing regular recent activity in the repo, and given this PR has been open for several months now, I thought I'd ping the people who have been pushing commits recently, for feedback on whether (and when, if so) this change will be considered: @phillmv, @anticomputer, @kevinbackhouse. I'd appreciate any input!

@kevinbackhouse
Copy link
Collaborator

I'm from the security team, and all of my activity has been bug-fixing. I have no opinion on this marker-vs-delimiter naming question. The code change looks harmless to me, so I'm fine with approving it if people think it's important.

@anticomputer anticomputer merged commit 63dd7b7 into github:master Jul 20, 2023
@waldyrious waldyrious deleted the marker-vs-delimiter branch July 20, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants