Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plaintext rendering for footnotes. #126

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Add plaintext rendering for footnotes. #126

merged 1 commit into from
Oct 17, 2018

Conversation

Xadeck
Copy link

@Xadeck Xadeck commented Oct 17, 2018

Otherwise, it crashes in debug mode. Reproduction:

make debug
build/src/cmark-gfm --to plaintext --extension footnotes <<EOF
Paragraph with [^1] footnote.

[^1]:this is the footnote
EOF
aborted

After the change, it is:

make debug
build/src/cmark-gfm --to plaintext --extension footnotes <<EOF
Paragraph with [^1] footnote.

[^1]:this is the footnote
EOF
Paragraph with [^1] footnote.

[^1]: this is the footnote

mode. Reproduction:

```
make debug
build/src/cmark-gfm --to plaintext --extension footnotes <<EOF
Paragraph with [^1] footnote.

[^1]:this is the footnote
EOF
aborted
```

After the change, it is:

```
make debug
build/src/cmark-gfm --to plaintext --extension footnotes <<EOF
Paragraph with [^1] footnote.

[^1]:this is the footnote
EOF
Paragraph with [^1] footnote.

[^1]: this is the footnote
```
@kivikakk
Copy link

❤️ Thank you so much for all your PRs.

@kivikakk kivikakk merged commit bbb9dd1 into github:master Oct 17, 2018
talum pushed a commit that referenced this pull request Sep 14, 2021
…#126)

mode. Reproduction:

```
make debug
build/src/cmark-gfm --to plaintext --extension footnotes <<EOF
Paragraph with [^1] footnote.

[^1]:this is the footnote
EOF
aborted
```

After the change, it is:

```
make debug
build/src/cmark-gfm --to plaintext --extension footnotes <<EOF
Paragraph with [^1] footnote.

[^1]:this is the footnote
EOF
Paragraph with [^1] footnote.

[^1]: this is the footnote
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants