Limit the recursion in autolink extension. #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not really a bug, but it's possible to send an input markdown consisting of lots of @ signs, and the recursion will cause memory explosion. The limit depends on the running environment, but there is no reason to accept arbitrarily long sequence of @, so let's just cut off at 1000.
|
The bug in this PR was found through fuzzing through the Google Autofuzz project. Autofuzz is an internal project, but a similar service is offered for free to open-source software. This is called OSS-Fuzz and described on the Google Opensource blog. |
|
Thank you! |
talum
pushed a commit
that referenced
this pull request
Sep 14, 2021
This is not really a bug, but it's possible to send an input markdown consisting of lots of @ signs, and the recursion will cause memory explosion. The limit depends on the running environment, but there is no reason to accept arbitrarily long sequence of @, so let's just cut off at 1000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not really a bug, but it's possible to send an input markdown
consisting of lots of @ signs, and the recursion will cause memory
explosion. The limit depends on the running environment, but there is no
reason to accept arbitrarily long sequence of @, so let's just cut off
at 1000.