Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Caddyfile #6862

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

willnorris
Copy link
Contributor

Add support for Caddyfile, one of the main configuration formats of the Caddy web server.

Checklist:

/cc @mholt as fyi

@willnorris willnorris requested a review from a team as a code owner June 1, 2024 07:12
@willnorris willnorris force-pushed the willnorris/caddyfile branch 3 times, most recently from 64c4536 to 54ac768 Compare June 2, 2024 03:30
@mholt
Copy link

mholt commented Jun 2, 2024

Ohh this would be awesome for so many users! Thank you Will.

@lildude lildude changed the title add support for Caddyfile Support for Caddyfile Jun 6, 2024
@lildude lildude changed the title Support for Caddyfile Add support for Caddyfile Jun 6, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 7, 2024
Merged via the queue into github-linguist:master with commit 1149d0f Jun 7, 2024
5 checks passed
@wooorm
Copy link
Contributor

wooorm commented Jun 10, 2024

This seems to be the first scope with a capital letter. Is that intentional? Given that all others use lowercase, shouldn’t this too?

@Kikki005

This comment was marked as spam.

@lildude
Copy link
Member

lildude commented Jun 11, 2024

This seems to be the first scope with a capital letter. Is that intentional? Given that all others use lowercase, shouldn’t this too?

You'd need to ask the grammar maintainers as that's how it is defined in the grammar and is where we get it from.

I don't believe there is a requirement that only lowercase letters be used; it's probably just common practise. Either way, GitHub's syntax highlighting doesn't have a problem with the case used for the scope name

@wooorm
Copy link
Contributor

wooorm commented Jun 11, 2024

/cc @matthewpi


Either way, GitHub's syntax highlighting doesn't have a problem with the case used for the scope name

Are you sure? I was wondering about this too, but as the GH site is behind, I can’t confirm it.
I wonder because there’s also a source.pov-ray sdl here, which turns into two separate classes on GH web.
In my case, scopes turn into file names, and given that case-sensitivity between file systems varies, I foresee it might get fragile.

@lildude
Copy link
Member

lildude commented Jun 11, 2024

Are you sure?

Yes, in as much as Caddyfiles are getting syntax highlighting on GitHub, and they're only getting it because the syntax highlighter has correctly associated source.Caddyfile with the Caddyfile language and associated grammar. Any problems with that highlighting of part of these files is entirely up to the grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants