-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Caddyfile #6862
Add support for Caddyfile #6862
Conversation
64c4536
to
54ac768
Compare
54ac768
to
0b1805e
Compare
Ohh this would be awesome for so many users! Thank you Will. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
This seems to be the first scope with a capital letter. Is that intentional? Given that all others use lowercase, shouldn’t this too? |
This comment was marked as spam.
This comment was marked as spam.
You'd need to ask the grammar maintainers as that's how it is defined in the grammar and is where we get it from. I don't believe there is a requirement that only lowercase letters be used; it's probably just common practise. Either way, GitHub's syntax highlighting doesn't have a problem with the case used for the scope name |
/cc @matthewpi
Are you sure? I was wondering about this too, but as the GH site is behind, I can’t confirm it. |
Yes, in as much as Caddyfiles are getting syntax highlighting on GitHub, and they're only getting it because the syntax highlighter has correctly associated |
Add support for Caddyfile, one of the main configuration formats of the Caddy web server.
Checklist:
#22b638
/cc @mholt as fyi