Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dune (OCaml build system) #6814

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kisaragi-hiu
Copy link

@kisaragi-hiu kisaragi-hiu commented May 6, 2024

Description

Dune is a build system for OCaml, used in a large number of OCaml projects. This PR adds classification and syntax highlighting support for it.

I specified ace_mode: lisp because Dune is an Sexp-based language. I'm guessing that this is appropriate.

Checklist:

@kisaragi-hiu kisaragi-hiu requested a review from a team as a code owner May 6, 2024 17:04
@kisaragi-hiu kisaragi-hiu changed the title Add Dune Add Dune (OCaml build system) May 14, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as pending popularity as the two workspace files aren't sufficient yet.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this with fresh eyes, I don't think it makes sense splitting this out into different languages. They all share the same grammar and are grouped together so it makes sense to put them all into a single Dune language definition.

I note you've manually set each entry in this PR with a different scopes, however the upstream grammar only has a single source.dune so your other scopes won't work. This also further confirms these are all the same language so don't need separate entries.

Please merge these languages into a single Dune language.

Since they all share the same grammar, they should just be considered as
one language. The grammar used also only defines one source.dune scope.
@kisaragi-hiu
Copy link
Author

Merged the three previously declared languages into one and rebased onto master.

The split was left over from when I was trying to use ocamllabs/vscode-ocaml-platform (which has the split for different vocabulary), and I left it in by mistake when I switched to maelvls/vscode-dune due to errors when I tried the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants