Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slint #6750

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Add Slint #6750

merged 1 commit into from
Mar 13, 2024

Conversation

ogoffart
Copy link
Contributor

Description

Add the Slint language

Checklist:

@ogoffart ogoffart requested a review from a team as a code owner March 12, 2024 15:27
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of your samples are too big as they're being suppressed by the diff by default. Please replace these with smaller samples.

You need to also add the cached license .yml file that would have been created when you ran script/add-grammar to add the grammar.

@ogoffart
Copy link
Contributor Author

Two of your samples are too big as they're being suppressed by the diff by default. Please replace these with smaller samples.

I edited them to removed big parts so they are small enough.

You need to also add the cached license .yml file that would have been created when you ran script/add-grammar to add the grammar.

Added.

@ogoffart
Copy link
Contributor Author

I had forgotten to git add this file. I tried to clean everything and re-create it and that didn't work at first. Now this should be the correct one.

@ogoffart ogoffart requested a review from lildude March 12, 2024 18:23
@lildude
Copy link
Member

lildude commented Mar 12, 2024

I had forgotten to git add this file. I tried to clean everything and re-create it and that didn't work at first. Now this should be the correct one.

Whoops! There's only one file change now.

@ogoffart
Copy link
Contributor Author

Whoops! There's only one file change now.

Sorry about that.
I'm doing this in codespaces which I'm not familiar with. Should be alright now.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now.

@lildude lildude added this pull request to the merge queue Mar 13, 2024
Merged via the queue into github-linguist:master with commit 82e2cc3 Mar 13, 2024
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants