Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pnpm lockfiles as generated #6749

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Add pnpm lockfiles as generated #6749

merged 7 commits into from
Mar 12, 2024

Conversation

SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented Mar 12, 2024

Description

Currently, npm lockfiles (package-lock.json) are considered generated files. pnpm lockfiles weren't marked as generated, even though they are indeed generated files

Checklist:

@SuperchupuDev SuperchupuDev requested a review from a team as a code owner March 12, 2024 13:37
@SuperchupuDev
Copy link
Contributor Author

SuperchupuDev commented Mar 12, 2024

Let me know if I need to change or add anything, this is my first PR to this repo

@SuperchupuDev
Copy link
Contributor Author

I see it was decided in #4348 not to mark yarn lockfiles as generated. Would pnpm lockfiles fall under the same boat? If not, why are npm lockfiles marked as generated but not these ones?

@SuperchupuDev SuperchupuDev changed the title add yarn and pnpm lockfiles as generated Add yarn and pnpm lockfiles as generated Mar 12, 2024
@lildude
Copy link
Member

lildude commented Mar 12, 2024

I see it was decided in #4348 not to mark yarn lockfiles as generated. Would pnpm lockfiles fall under the same boat?

Possibly. The decision to not mark yarn lockfiles came from community feedback so we will not be going back on this unless requested by the wider community.

If not, why are npm lockfiles marked as generated but not these ones?

No idea. Maybe because package-lock.json was added to Linguist over 7 years ago and maybe pnpm didn't exist waaaay back then.

Let me know if I need to change or add anything, this is my first PR to this repo

Yes, remove the yarn lock related change. You'll also need to add tests and a sample. See #6748 as an example where a file has recently been marked as generated.

@SuperchupuDev SuperchupuDev marked this pull request as draft March 12, 2024 18:04
@SuperchupuDev SuperchupuDev changed the title Add yarn and pnpm lockfiles as generated Add pnpm lockfiles as generated Mar 12, 2024
@SuperchupuDev
Copy link
Contributor Author

SuperchupuDev commented Mar 12, 2024

Yes, remove the yarn lock related change. You'll also need to add tests and a sample. See #6748 as an example where a file has recently been marked as generated.

Done. I tried to find a small sample of a pnpm lockfile but this 9k line one was the smallest I could find for a relevant enough project. I hope that's not much of a problem

@SuperchupuDev SuperchupuDev marked this pull request as ready for review March 12, 2024 18:41
@lildude
Copy link
Member

lildude commented Mar 12, 2024

I hope that's not much of a problem

It is… hooooge. Please find a smaller one. We don't need a real world file for test fixtures so feel free to write a small representative one by hand if you can't find a smaller one.

@lildude lildude added this pull request to the merge queue Mar 12, 2024
Merged via the queue into github-linguist:master with commit 28b457e Mar 12, 2024
5 checks passed
@SuperchupuDev SuperchupuDev deleted the patch-1 branch March 12, 2024 20:13
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants