Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pkl language #6730

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Add Pkl language #6730

merged 5 commits into from
Jun 7, 2024

Conversation

stackoverflow
Copy link
Contributor

@stackoverflow stackoverflow commented Mar 1, 2024

Description

Adds support for the Pkl programming language.

Checklist:

@stackoverflow stackoverflow requested a review from a team as a code owner March 1, 2024 09:55
@stackoverflow
Copy link
Contributor Author

stackoverflow commented Mar 1, 2024

I've tried to remove our org from the language search but I'm not sure the syntax supports it.
Filtered our repos.

lildude
lildude previously requested changes Mar 1, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

I've tried to remove our org from the language search but I'm not sure the syntax supports it.

Sure does. Add NOT user:apple to the query.

color: "#6b9543"
extensions:
- ".pkl"
- ".pcf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need samples and supporting searches for all extensions and filenames added to a PR. If usage isn't sufficient, support can be added later and an override can be used in the interim.

Also keep in mind that the same grammar and thus syntax highlighting will be applied to all extensions and filenames associated with a language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need samples and supporting searches for all extensions and filenames added to a PR. If usage isn't sufficient, support can be added later and an override can be used in the interim.

Oh, I guess I missed that and thought they could be lumped together as they are just different extensions/names for the same language.
What do you mean by an override can be used in the interim.?

Also keep in mind that the same grammar and thus syntax highlighting will be applied to all extensions and filenames associated with a language.

That is fine. Both .pcf and PklProject are just Pkl files. pcf is a subset of Pkl.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by an override can be used in the interim.?

https://github.com/github-linguist/linguist/blob/master/docs/overrides.md

@stackoverflow
Copy link
Contributor Author

stackoverflow commented Mar 1, 2024

@lildude I removed .pcf and PklProject from the list of file names and extensions. We don't have the expected usage data yet. Will add this later as a separate PR once we do have the data.

For some reason my last commit didn't appear in the PR even though it's there if you click the branch...

@lildude lildude changed the title add Pkl language Add Pkl language Mar 12, 2024
@stackoverflow
Copy link
Contributor Author

Hi @lildude. Are we still pending on popularity? There's considerably more pkl files in the search since I created this PR.

@lildude
Copy link
Member

lildude commented Mar 26, 2024

I don't know. I'll re-assess when we're closer to making the next release. As we've just made a release, the next one won't be for a few more months.

@Senjai
Copy link

Senjai commented May 29, 2024

Just commenting for context RE: Popularity, we're currently using this in one or two of Shopify's internal repositories. I'd like to pitch using this for some of our external open source stuff, but there is a bit of chicken-and-egg there since we want the Github experience to be fantastic for our open source projects as well. Just adding another viewpoint if it helps at all.

@lildude Popularity aside, are you generally okay with the implementation here?

@hugolgst
Copy link

hugolgst commented Jun 1, 2024

any updates? would love to see it move forward.

@lildude lildude self-requested a review June 2, 2024 05:31
@lildude lildude dismissed their stale review June 2, 2024 05:32

Changes have been implemented. Popularity will be reassessed closer to the next release.

@lildude lildude added this pull request to the merge queue Jun 7, 2024
Merged via the queue into github-linguist:master with commit ebe6ef7 Jun 7, 2024
5 checks passed
@hugolgst
Copy link

amazing!!

@stackoverflow stackoverflow deleted the pkl-support branch June 11, 2024 10:13
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants