-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pkl language #6730
Add Pkl language #6730
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
I've tried to remove our org from the language search but I'm not sure the syntax supports it.
Sure does. Add NOT user:apple
to the query.
lib/linguist/languages.yml
Outdated
color: "#6b9543" | ||
extensions: | ||
- ".pkl" | ||
- ".pcf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need samples and supporting searches for all extensions and filenames added to a PR. If usage isn't sufficient, support can be added later and an override can be used in the interim.
Also keep in mind that the same grammar and thus syntax highlighting will be applied to all extensions and filenames associated with a language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need samples and supporting searches for all extensions and filenames added to a PR. If usage isn't sufficient, support can be added later and an override can be used in the interim.
Oh, I guess I missed that and thought they could be lumped together as they are just different extensions/names for the same language.
What do you mean by an override can be used in the interim.
?
Also keep in mind that the same grammar and thus syntax highlighting will be applied to all extensions and filenames associated with a language.
That is fine. Both .pcf
and PklProject
are just Pkl files. pcf
is a subset of Pkl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by
an override can be used in the interim.
?
https://github.com/github-linguist/linguist/blob/master/docs/overrides.md
@lildude I removed
|
5c34cda
to
9546b99
Compare
Hi @lildude. Are we still pending on popularity? There's considerably more pkl files in the search since I created this PR. |
I don't know. I'll re-assess when we're closer to making the next release. As we've just made a release, the next one won't be for a few more months. |
Just commenting for context RE: Popularity, we're currently using this in one or two of Shopify's internal repositories. I'd like to pitch using this for some of our external open source stuff, but there is a bit of chicken-and-egg there since we want the Github experience to be fantastic for our open source projects as well. Just adding another viewpoint if it helps at all. @lildude Popularity aside, are you generally okay with the implementation here? |
any updates? would love to see it move forward. |
Changes have been implemented. Popularity will be reassessed closer to the next release.
amazing!! |
Description
Adds support for the Pkl programming language.
Checklist:
#6b9543