Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextMate Scope for '.ice' Files #6714

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

InsertCreativityHere
Copy link
Contributor

@InsertCreativityHere InsertCreativityHere commented Feb 21, 2024

Hello! I'm the maintainer of the Slice language!

A few months ago, we released a new 'edition' of our language's syntax, so there are now 2 separate syntaxes for Slice.
By convention, the original syntax uses (and has always used) .ice file suffixes. The new syntax uses .slice file suffixes.
Due to the difference in syntax, each uses it's own highlighter. You can see them here:
https://github.com/zeroc-ice/vscode-slice/tree/main/syntaxes
Note that this is already the grammar repo used by Linguist:

- **Slice:** [zeroc-ice/vscode-slice](https://github.com/zeroc-ice/vscode-slice)

As part of this change, we modified the TM scope associated with .ice files from source.slice to source.ice
(so we could use the source.slice TM scope for the new syntax).
This change took place here: zeroc-ice/vscode-slice@ab6bf2d

I acknowledge this is probably a fairly unorthodox thing to do, so any guidance on what's the best way to proceed would be appreciated! But, as the absolute least, I opened this PR because the highlighting for .ice files is currently broken, as they're pulling in the TM scope for the new syntax.

Checklist:

@InsertCreativityHere InsertCreativityHere requested a review from a team as a code owner February 21, 2024 22:28
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit 66cfa62 Mar 8, 2024
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants