Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overpass QL #6709

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Add Overpass QL #6709

merged 2 commits into from
Jun 7, 2024

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Feb 15, 2024

Closes #6311

Description

See extensive description in issue #6311

Checklist:

@k-yle k-yle requested a review from a team as a code owner February 15, 2024 08:01
@FloEdelmann
Copy link

Thanks for the ping and thanks a lot for the PR! This was on my todo list for way to long.

When/if this is merged, it might be worth creating a short blog entry for WeeklyOSM to mention that .overpassql files now have syntax highlighting on GitHub, and also linking @tqdv's VS Code extension.

@lildude lildude changed the title add Overpass QL as a language Add Overpass QL Feb 20, 2024
@lildude lildude added this pull request to the merge queue Jun 7, 2024
Merged via the queue into github-linguist:master with commit 6c26c74 Jun 7, 2024
5 checks passed
@lildude
Copy link
Member

lildude commented Jun 7, 2024

Reverting this as you appear to have added the grammar directly rather than using the script:

$ script/add-grammar --replace vendor/grammars/vscodium-overpassql-syntax https://github.com/tqdv/vscodium-overpassql-syntax
Checking Docker is installed and running
Deregistering submodule: vendor/grammars/vscodium-overpassql-syntax
Cleared directory 'vendor/grammars/vscodium-overpassql-syntax'
Submodule 'vendor/grammars/vscodium-overpassql-syntax' (https://github.com/tqdv/vscodium-overpassql-syntax.git) unregistered for path 'vendor/grammars/vscodium-overpassql-syntax'
rm 'vendor/grammars/vscodium-overpassql-syntax'
Registering new submodule: https://github.com/tqdv/vscodium-overpassql-syntax.git
Reactivating local git directory for submodule 'vendor/grammars/vscodium-overpassql-syntax'
latest: Pulling from linguist/grammar-compiler
Digest: sha256:fcaf08a6e27d3d88212d9ca8aceee30d4089499a77bb05307871febd8073790f
Status: Image is up to date for linguist/grammar-compiler:latest
docker.io/linguist/grammar-compiler:latest
source 'vendor/grammars/vscodium-overpassql-syntax' contains no grammar files
$

This is happening because the grammar repo is not correctly structured.

lildude added a commit that referenced this pull request Jun 7, 2024
@lildude lildude mentioned this pull request Jun 7, 2024
lildude added a commit that referenced this pull request Jun 7, 2024
Revert "Add Overpass QL (#6709)"

This reverts commit 6c26c74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Overpass QL
3 participants