Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language definition for Uxntal. #6648

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

non
Copy link

@non non commented Dec 21, 2023

Add language definition for Uxntal.

Description

Uxntal is an assembly language for the Varvara virtual machine.

Uxntal assmebly is compiled into ROMs. Emulators to run these ROMs exist for a wide variety of hardware.

I found around 268 Uxn repositories on Github and around 1k paths. Given that most projects consist of 1-3 .tal files I believe this meets the criteria for inclusion. Uxn has also been written about in the press.

The samples are MIT-licensed programs taken from the main project:

Checklist:

[Uxntal](https://wiki.xxiivv.com/site/uxntal.html) is an assembly language for the [Varvara](https://wiki.xxiivv.com/site/varvara.html) virtual machine.

Uxntal assmebly is compiled into ROMs. Emulators to run these ROMs exist for a [wide variety of hardware](https://github.com/hundredrabbits/awesome-uxn#emulators).

Using various search terms I get the following picture of Uxntal's popularity:

 - Searching for "uxn" I find 268 repos
 - Searching for "varvara" I find 208 repos
 - Searching for "*.tal" files I find 1k files

Given that most projects consist of 1-3 .tal files I believe this meets the criteria for inclusion. Uxn has also been [written about in the press](https://www.theverge.com/22935074/hundred-rabbits-uxn-roms-preservation).

The samples are MIT-licensed programs taken from the main project:

 - [mandelbrot.tal](https://git.sr.ht/~rabbits/uxn/tree/main/item/projects/examples/demos/mandelbrot.tal)
 - [piano.tal](https://git.sr.ht/~rabbits/uxn/tree/main/item/projects/software/piano.tal)
@non non requested a review from a team as a code owner December 21, 2023 19:33
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

Also, samples/Uxntal/piano.tal is too big (if it's suppressed in the diff, it's too big). Please replace it with a smaller real-world sample.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
 - replace piano.tal with dvd.tal
 - run script/update-ids
@non
Copy link
Author

non commented Dec 22, 2023

Alright, I replaced piano.tal with the much smaller dvd.tal and ran script/update-ids.

@non non requested a review from lildude December 22, 2023 14:57
@non
Copy link
Author

non commented Jan 9, 2024

I think this is ready to go, but please let me know if there's anything else missing.

@lildude lildude dismissed their stale review July 10, 2024 09:15

Requested changes have been applied. Just pending popularity now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants