Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bluespec BH TextMate grammar #6644

Merged

Conversation

quark17
Copy link
Contributor

@quark17 quark17 commented Dec 20, 2023

Description

Earlier this year, we added Bluespec BH as a language (in the Bluespec group), but there was no TextMate grammar for it, so we pointed to the Haskell grammar, since it's similar and better than nothing. There is now a TextMate grammar for Bluespec BH, so this PR adds that as a submodule (using the add-grammar script) and updates the Bluespec BH record to point to it.

The repo (B-Lang-org/language-bh) is maintained by B-Lang-org, the organization that maintains the open-source BSC compiler. The grammar was adapted from an existing Haskell grammar, with only a few changes so far, but I hope to see more development. If I understand, when Linguist releases are made, the submodules are updated to newer commits; I won't have to submit new PRs to update this submodule.

I am unaware of anything I can run to test the highlighter changes, although I assume that script/add-grammar performed some checks.

Checklist:

  • I am adding a new extension to a language.

    • The new extension is used in hundreds of repositories on GitHub.com
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am adding a new language.

    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a syntax highlighting grammar: [URL to grammar repo]
    • I have added a color
      • Hex value: #RRGGBB
      • Rationale:
    • I have updated the heuristics to distinguish my language from others using the same extension.
  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@quark17 quark17 requested a review from a team as a code owner December 20, 2023 01:55
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit ac6d8c5 Mar 8, 2024
5 checks passed
@quark17 quark17 deleted the update-bluespec-bh-tmgrammar branch March 8, 2024 23:27
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants