Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Praat scripting language #6620

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Conversation

JJWRoeloffs
Copy link
Contributor

Adding support for the Praat scripting language. This is a domain-specific language that is quite commonly used in academia for linguistic research, but that isn't that commonly known outside that sphere.

I am not affiliated with the project - I'm just a student who had to learn the language for a BA course, and was surprised github did not support it.

Description

If I did everything correctly, this commit adds support for the Praat scripting language in the way described by CONTRIBUTING.md

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample license(s):
        • I wrote these scripts myself as a part of a Research inter-ship, and am happy to re-licence them under linguist's MIT licence (which I am allowed to do following the terms of the internship).
    • I have included a syntax highlighting grammar: URL to grammar repo
    • I have added a color
      • Hex value: #c8506d
      • Rationale: Colour from the logo. The logo has a small gradient, so I picked the colour with the highest contrast out of the gradient to both black and white.

@JJWRoeloffs JJWRoeloffs requested a review from a team as a code owner December 3, 2023 01:00
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need the cached licence file. This should have been created when you used the script/add-grammar script. If you can't find the file, you can regenerate it by running this line manually:

bundle exec licensed cache -c vendor/licenses/config.yml

lib/linguist/languages.yml Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@JJWRoeloffs
Copy link
Contributor Author

I think all requested changes are done.

One question: What are the required steps for data files? Praat saves its data in a number of file formats, but the most notable is .TextGrid, which the vscode extension also has a grammar for. According to the recommended github search, there are over 100K files in this format checked in.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove vendor/grammars/Praat-tmLanguage

@JJWRoeloffs
Copy link
Contributor Author

Checked everything & updated with master. I think everything is ready at this point.

@lildude lildude added this pull request to the merge queue Dec 6, 2023
Merged via the queue into github-linguist:master with commit 6c4c9c1 Dec 6, 2023
5 checks passed
@JJWRoeloffs JJWRoeloffs mentioned this pull request Feb 25, 2024
5 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants