Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group name casing: prolog -> Prolog #6615

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented Nov 21, 2023

Description

There is a typo in a group name. The corresponding key name is Prolog.
https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml#L5362

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

I don't know if this point applies ^.

@varungandhi-src varungandhi-src requested a review from a team as a code owner November 21, 2023 03:25
@asif8419

This comment was marked as spam.

@varungandhi-src
Copy link
Contributor Author

@lildude is there anything else you'd like to see here?

@lildude
Copy link
Member

lildude commented Nov 24, 2023

Nope. This change isn't really necessary as the group name, like the language name, is not case sensitive as we always downcase when using the name for anything, but there's no harm in changing it.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Dec 5, 2023
Merged via the queue into github-linguist:master with commit 77d7f83 Dec 5, 2023
5 checks passed
@varungandhi-src varungandhi-src deleted the vg/fix-case branch December 5, 2023 14:13
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants