Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DM grammar source #6605

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

vvvv-vvvv
Copy link
Contributor

@vvvv-vvvv vvvv-vvvv commented Nov 8, 2023

Description

Changed the DM grammar to a better maintained source that has new keywords

Checklist:

@vvvv-vvvv vvvv-vvvv requested a review from a team as a code owner November 8, 2023 10:08
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't accept this change.

Whilst the grammar files are licensed under MIT, the over-all repo is licensed by GPL-3 which means we'll be shipping code that is covered by this license which we can't do.

I'm also not sure GPL3 allows sub-licensing, but that's not relevant as we don't include just the grammar files.

@vvvv-vvvv vvvv-vvvv marked this pull request as draft November 8, 2023 13:01
@vvvv-vvvv vvvv-vvvv changed the title Change DM grammar to SpaceManiac/vscode-dm-langclient Change DM grammar to vvvv-vvvv/dm-syntax Nov 9, 2023
@vvvv-vvvv
Copy link
Contributor Author

Is this fine? The samples for the new extensions are about as complicated as they can get, so they aren't from a real-world project

@vvvv-vvvv vvvv-vvvv marked this pull request as ready for review November 9, 2023 01:45
@lildude
Copy link
Member

lildude commented Nov 9, 2023

No. We want real world examples as documented. This is used to train the classifier. The .dme extension is also not popular enough for addition right now so will only hold back this PR.

@lildude lildude changed the title Change DM grammar to vvvv-vvvv/dm-syntax Change DM grammar source Nov 9, 2023
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@optimumtact
Copy link

thanks for taking on the grammar maintenance by the way vvvv.

@vvvv-vvvv
Copy link
Contributor Author

Moved the repo elsewhere

type: git_submodule
homepage: https://github.com/PJB3005/atomic-dreams
homepage: https://github.com/vvvv-vvvv/dm-syntax.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the URLs used elsewhere. If you used the script/add-grammar --replace command, it should have resulted in the same URL used elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, and it didn't replace this

@lildude lildude added this pull request to the merge queue Dec 5, 2023
Merged via the queue into github-linguist:master with commit 09d9842 Dec 5, 2023
5 checks passed
@optimumtact
Copy link

thanks lildude

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants