Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform Template language #6604

Merged
merged 14 commits into from
Dec 12, 2023

Conversation

johnmays
Copy link
Contributor

@johnmays johnmays commented Nov 5, 2023

Description

Closes #6562

I added Terraform Template as a new markup language. Terraform template files are used to automatically add syntax when given a set of arguments in Terraform. See the Terraform documentation page for more information.

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
    • I have included a syntax highlighting grammar (uses MPL 2.0)
    • I have added a color
      • Hex value: #7B42BB
      • Rationale: It is one of the purples Hashicorp, the developers of Terraform, officially use for it. The purple in use for the Terraform (AKA "HCL") language is the other purple. It is similar, but noticeably brighter. They have these two official purples listed on in their brand page for Terraform.
    • I have updated the heuristics to distinguish my language from others using the same extension.
      • No other languages use .tftpl, so there is no need.

Misc. Note:

I did list the Terraform Template Language in the HCL group. (HCL is the primary alias for Terraform). This will count it as HCL instead of its own language. I think this is appropriate, but I'm not 100% sure. I'm also not sure if that dismisses the need for a color choice.

@johnmays johnmays requested a review from a team as a code owner November 5, 2023 09:27
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the test failed. My comment inline will deal with the interpreter/shell failures.

samples/Terraform Template/os_alpine_3_17_userdata.tftpl Outdated Show resolved Hide resolved
@johnmays
Copy link
Contributor Author

johnmays commented Dec 8, 2023

Please address the test failed. My comment inline will deal with the interpreter/shell failures.

I removed the sample, ran the tests locally (they passed), and pushed. Sorry, I am kind of new to this, but should I resolve the conflicts in .gitmodules or will that be addressed when you merge?

@johnmays johnmays requested a review from lildude December 8, 2023 06:08
@lildude
Copy link
Member

lildude commented Dec 8, 2023

Please address the test failed. My comment inline will deal with the interpreter/shell failures.

I removed the sample, ran the tests locally (they passed), and pushed. Sorry, I am kind of new to this, but should I resolve the conflicts in .gitmodules or will that be addressed when you merge?

It's best if you do it

@johnmays
Copy link
Contributor Author

johnmays commented Dec 8, 2023

Please address the test failed. My comment inline will deal with the interpreter/shell failures.

I removed the sample, ran the tests locally (they passed), and pushed. Sorry, I am kind of new to this, but should I resolve the conflicts in .gitmodules or will that be addressed when you merge?

It's best if you do it

It's done.

.gitmodules Outdated Show resolved Hide resolved
@johnmays johnmays requested a review from lildude December 8, 2023 09:51
@lildude
Copy link
Member

lildude commented Dec 12, 2023

Sorry about the noise. Something really went awry with the submodules and cached licenses which took a while to get right, but we should be good to go now. CI should pass now 🤞

@lildude lildude added this pull request to the merge queue Dec 12, 2023
Merged via the queue into github-linguist:master with commit 8c380f3 Dec 12, 2023
5 checks passed
@johnmays
Copy link
Contributor Author

Sorry about the noise. Something really went awry with the submodules and cached licenses which took a while to get right, but we should be good to go now. CI should pass now 🤞

All good. Very nice to see.

@johnmays johnmays deleted the feature/Terraform-templates branch December 14, 2023 16:17
@johnmays johnmays restored the feature/Terraform-templates branch December 14, 2023 16:17
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New language: Terraform templates
2 participants