Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color for Sway #6498

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Update color for Sway #6498

merged 3 commits into from
Dec 5, 2023

Conversation

sdankel
Copy link
Contributor

@sdankel sdankel commented Aug 2, 2023

Changing the color for the Sway language to Fuel Labs' green.

image

Checklist:

@sdankel sdankel marked this pull request as ready for review October 31, 2023 04:23
@sdankel sdankel requested a review from a team as a code owner October 31, 2023 04:23
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have obtained agreement from the wider language community on this color change.
[URL to public discussion]
[Optional: URL to official branding guidelines for the language]

No you haven't 😉

You can't blindly change the language without filling this in. This is strictly enforced as people are sensitive about these things.

See https://github.com/github-linguist/linguist/blob/master/CONTRIBUTING.md#changing-the-color-associated-with-a-language for more details

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@sdankel sdankel marked this pull request as draft October 31, 2023 19:01
@sdankel
Copy link
Contributor Author

sdankel commented Oct 31, 2023

Putting this back in draft as the design team discusses internally. They'll post on this PR when a decision is reached.

@lildude
Copy link
Member

lildude commented Oct 31, 2023

Public discussion on this PR

Please don’t. The discussion needs to take place publicly in your community forums and referenced in this PR. Not here.

@sdankel sdankel marked this pull request as ready for review November 16, 2023 14:55
@sdankel sdankel requested a review from lildude November 16, 2023 14:55
@sdankel
Copy link
Contributor Author

sdankel commented Nov 22, 2023

@lildude I updated the link to our community forum with discussion and a poll. Let me know if this works.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Dec 5, 2023
Merged via the queue into github-linguist:master with commit 7ef9368 Dec 5, 2023
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants