Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hosts to Host file aliases #6486

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Jul 22, 2023

Description

I couldn't get [attr]hosts linguist-detectable linguist-language=hosts to have any effect on files in my repo, so I took a guess that something seemed off with Linguist-Language's accepted values.

(Checklist removed as it doesn't apply)

@DandelionSprout DandelionSprout requested a review from a team as a code owner July 22, 2023 16:13
@Alhadis Alhadis changed the title Adding a "hosts" alias just in case Add hosts to Host file aliases Jul 25, 2023
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. Did I really forget to include hosts as an alias when preparing #6391? 🤔 I must be getting sloppy… 😞

Thanks!

@DandelionSprout
Copy link
Contributor Author

What is taking the repo leaders so long? This is becoming a bit odd.

@lildude
Copy link
Member

lildude commented Aug 25, 2023

Not odd at all… there is only me and Linguist is not my primary role at GitHub. PRs are only merged if they have an immediate impact or when we're getting close to making a release so small patch releases can be made if necessary. The Linguist release cycle is based loosely around the GitHub Enterprise Server release cycle as detailed in the docs. A new patch, or possibly a full release, will be made once #6518 has been merged. I'll assess it at the time.

@lildude lildude added this pull request to the merge queue Sep 7, 2023
Merged via the queue into github-linguist:master with commit f36d835 Sep 7, 2023
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants