Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VBA grammar #6440

Merged
merged 7 commits into from
Jun 5, 2023
Merged

Add VBA grammar #6440

merged 7 commits into from
Jun 5, 2023

Conversation

DecimalTurn
Copy link
Contributor

@DecimalTurn DecimalTurn commented Jun 4, 2023

This PR replaces the current VBA grammar that is actually for VB.NET by a grammar specific to VBA.

See also #6436 and serkonda7/vscode-vba#76

Description

Checklist:

@DecimalTurn DecimalTurn force-pushed the vba-grammar branch 2 times, most recently from 3d79f0f to 1dd0b5e Compare June 4, 2023 06:31
@DecimalTurn DecimalTurn force-pushed the vba-grammar branch 2 times, most recently from 3cd3027 to c0320ef Compare June 4, 2023 17:32
@DecimalTurn DecimalTurn marked this pull request as ready for review June 5, 2023 02:12
@DecimalTurn DecimalTurn requested a review from a team as a code owner June 5, 2023 02:12
@DecimalTurn
Copy link
Contributor Author

This PR is now ready for review.

Note that the submodule update was needed to fix these errors.

Also thanks to @serkonda7 for the help on this and for supplying the grammar.

Copy link
Contributor

@serkonda7 serkonda7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

grammars.yml Show resolved Hide resolved
@lildude lildude added this pull request to the merge queue Jun 5, 2023
Merged via the queue into github-linguist:master with commit 4f337d9 Jun 5, 2023
5 checks passed
@DecimalTurn DecimalTurn deleted the vba-grammar branch September 16, 2023 19:06
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants