Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grammar for LOLCODE #6434

Merged
merged 3 commits into from
May 30, 2023
Merged

Add grammar for LOLCODE #6434

merged 3 commits into from
May 30, 2023

Conversation

KrazIvan
Copy link
Contributor

Made a grammar for LOLCODE since it doesn't have it. MIT-licensed.

Checklist:

@Alhadis
Copy link
Collaborator

Alhadis commented May 28, 2023

The human-readable list of grammars hasn't been updated. Did you forget to use script/add-grammar to add the grammar?

script/add-grammar KrazIvan/LOLCODE-grammar-vscode

@KrazIvan
Copy link
Contributor Author

KrazIvan commented May 29, 2023 •
edited
Loading

It's updated now. Sorry, seems like the new list of grammars wasn't committed. I used script/add-grammar, yes.

@lildude lildude requested a review from a team as a code owner May 30, 2023 08:56
lildude
lildude approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit 5a62830 May 30, 2023
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KrazIvan @Alhadis @lildude