Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source of "Adblock Filter List" grammar #6392

Merged
merged 2 commits into from
May 30, 2023

Conversation

scripthunter7
Copy link
Contributor

@scripthunter7 scripthunter7 commented Apr 27, 2023

Description

We moved the adblock syntax highlighter repo under the company organization, and this PR specifies the new location for proper Linguist integration. In addition, we changed the format of the grammar from JSON to YAML-TMLanguage, although if I understand everything correctly, this is a supported format that can be natively parsed by Linguist, and there is no further action from our side.

If you still need any action / information from us, feel free to ask in the comments.

Thank you!

CC @ameshkov

Checklist:

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude changed the title Update source for VscodeAdblockSyntax Change source for "Adblock Filter List" grammar May 17, 2023
@lildude lildude changed the title Change source for "Adblock Filter List" grammar Change source of "Adblock Filter List" grammar May 17, 2023
@lildude lildude requested a review from a team as a code owner May 30, 2023 09:13
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit 7ede0ba May 30, 2023
5 checks passed
@scripthunter7 scripthunter7 deleted the fix/adblock branch May 30, 2023 10:38
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants