Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WebAssembly Interface Types #6376

Merged
merged 8 commits into from
May 30, 2023

Conversation

eduardomourar
Copy link
Contributor

Description

Add support for WebAssembly Interface Type (WIT):
https://github.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md

Checklist:

@eduardomourar eduardomourar requested a review from a team as a code owner April 14, 2023 21:03
@Alhadis Alhadis changed the title feat: add support for WebAssembly Interface Type Add support for WebAssembly Interface Types Apr 14, 2023
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first grammar I've encountered that uses repository fields in contexts that aren't the top-level grammar object. I see that VSCode supports this, but Atom doesn't—and by extension, that (probably) includes PrettyLights (GitHub's implementation of TextMate's highlighting system, which is closed-source).

So comments will end up looking something like this on GitHub:

Figure 1

This can be solved by moving every named rule to the top-level repository object.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@eduardomourar
Copy link
Contributor Author

The repository fields have been moved to the top-level object.

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, grammar's looking good. The syntax highlighting grammar, I mean, not that of my Dunglish:

Figure 1

I noticed a few omissions in your grammar, but nothing urgent. I'll submit an issue to vscode-wit later with more info.

@eduardomourar
Copy link
Contributor Author

@Alhadis, I believe the license needs to be reviewed. It should be straightforward because it is Apache 2.0 with LLVM exception.

@Alhadis
Copy link
Collaborator

Alhadis commented Apr 25, 2023

/cc @lildude for license review

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude requested a review from a team as a code owner May 30, 2023 09:14
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit 6e849ff May 30, 2023
5 checks passed
@eduardomourar eduardomourar deleted the feat/add-wit-grammar branch May 30, 2023 14:08
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants