Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto alias for protobuf #6334

Merged
merged 4 commits into from
May 30, 2023
Merged

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Mar 21, 2023

proto is the extension for protobuf files, and is used in other syntax highlighters as the language id.

Description

Just adding the alias so that the proto language id can be used for code fences.

Checklist:

None of the below checklist items seem to apply

@dimitropoulos dimitropoulos requested a review from a team as a code owner March 21, 2023 16:29
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@Alhadis
Copy link
Collaborator

Alhadis commented Mar 27, 2023

Are we sure there's no risk of confusion for Cap’n Proto users? (I'm not a user of either technology, so I'm genuinely unsure).

@dimitropoulos
Copy link
Contributor Author

@Alhadis I don't think so, but I'm glad you mention it.

For one thing, many other highlighters already have the proto alias (including rouge, pigments, chroma, lowlight, refractor, prism, highlight.js). For another, the extension for Cap'n Proto is capnp anyway. Of those that also have Cap'n Proto highlighting, they seem to use capnp.

@Alhadis
Copy link
Collaborator

Alhadis commented Mar 28, 2023

@dimitropoulos Fair enough. Well, that answers my question nicely, then. 👍

@lildude lildude requested a review from a team as a code owner May 30, 2023 09:16
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit 6286724 May 30, 2023
5 checks passed
@dimitropoulos dimitropoulos deleted the protobuf branch May 30, 2023 19:08
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants