Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update licensed gem dependency #6333

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Update licensed gem dependency #6333

merged 3 commits into from
Mar 21, 2023

Conversation

lildude
Copy link
Member

@lildude lildude commented Mar 21, 2023

Description

Updates the licensed gem dependency to ~4.0.

Something has gone awry with licensed on macos with Ruby 3.2.0 which causes bundle exec licensed cache -c vendor/licenses/config.yml as run at the end of the script/add-grammar script to fail as follows as reported in #6330:

bundler: failed to load command: licensed (/Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/bin/licensed)
/Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/licensed-2.9.2/lib/licensed/commands/command.rb:18:in `run': wrong number of arguments (given 1, expected 0) (ArgumentError)
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/licensed-2.9.2/lib/licensed/cli.rb:83:in `run'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/licensed-2.9.2/lib/licensed/cli.rb:14:in `cache'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/thor-1.2.1/lib/thor/base.rb:485:in `start'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/gems/licensed-2.9.2/exe/licensed:5:in `<top (required)>'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/bin/licensed:25:in `load'
        from /Users/jessicalin/linguist/vendor/gems/ruby/3.2.0/bin/licensed:25:in `<top (required)>'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/cli/exec.rb:58:in `load'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/cli/exec.rb:58:in `kernel_load'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/cli/exec.rb:23:in `run'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/cli.rb:491:in `exec'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/cli.rb:34:in `dispatch'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/cli.rb:28:in `start'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/bundler-2.4.1/libexec/bundle:45:in `block in <top (required)>'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/3.2.0/bundler/friendly_errors.rb:117:in `with_friendly_errors'
        from /Users/jessicalin/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/bundler-2.4.1/libexec/bundle:33:in `<top (required)>'
        from /Users/jessicalin/.rbenv/versions/3.2.0/bin/bundle:25:in `load'
        from /Users/jessicalin/.rbenv/versions/3.2.0/bin/bundle:25:in `<main>'

This doesn't affect Linux from my testing but I have found that we're quite far behind on licensed and updating resolves the issue for me on macos without affecting Linux either.

@lildude lildude requested a review from a team as a code owner March 21, 2023 14:42
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes locally on macOS 12.6.3 and they LGTM. 👍

@lildude lildude merged commit 5c40ebb into master Mar 21, 2023
@lildude lildude deleted the lildude/update-licensed branch March 21, 2023 18:42
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants