Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .swcrc to "JSON with Comments" #6328

Merged
merged 3 commits into from
May 30, 2023
Merged

Add .swcrc to "JSON with Comments" #6328

merged 3 commits into from
May 30, 2023

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Mar 20, 2023

Description

Mark ".swcrc" as "JSON with Comments".

Checklist:

@g-plane g-plane requested a review from a team as a code owner March 20, 2023 06:44
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included a real-world usage sample for all extensions added in this PR:

Please update this to link to the actual source of this file, not your fork of this repo. We also need to know the license of the sample file (you accidentally deleted the "Sample license(s):" line for this).

@lildude lildude changed the title mark ".swcrc" as "JSON with Comments" Add .swcrc to "JSON with Comments" Mar 20, 2023
@g-plane
Copy link
Contributor Author

g-plane commented Mar 20, 2023

I copied from SWC playground default config with some modification, not an actual file. Is it OK?

@lildude
Copy link
Member

lildude commented Mar 20, 2023

Ok. That's fine. I've updated the OP to reflect this.

@lildude
Copy link
Member

lildude commented Mar 20, 2023

Note: this PR will not be merged until close to when the next release is made. See here for more details.

We've just made a release last week so the next one won't be for a few months.

@Alhadis Alhadis changed the title Add .swcrc to "JSON with Comments" Add .swcrc to "JSON with Comments" Mar 27, 2023
@lildude lildude requested a review from a team as a code owner May 30, 2023 09:16
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit 002f0ce May 30, 2023
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants