Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghcr.io for grammar compiler docker container #6322

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

lildude
Copy link
Member

@lildude lildude commented Mar 15, 2023

Description

Docker has release a very confusing message about the sunsetting of Free Team organizations. We use such a team organisation for storing the grammar compiler docker image and our choice to use this predates the introduction of the GitHub Packages registry.

It's not 100% sure how we'd be affected by this change, but suffice to say it's the motivator we need to stop using it. We don't really need to be using dockerhub, so this PR switches to using using ghcr.io.

This change will be hidden to most users.

[ Checklist doesn't apply ]

@lildude lildude requested a review from a team as a code owner March 15, 2023 11:32
@Alhadis
Copy link
Collaborator

Alhadis commented Mar 22, 2023

What's the reason for using Docker anyway? Wouldn't it have been easier to implement the grammar compiler in Ruby?

(I might be asking a dumb question… it's been a while since I've gone near that part of Linguist's codebase…)

@lildude
Copy link
Member Author

lildude commented Mar 22, 2023

When it was written, I believe the intention was to put prettylights into a standalone service and use protobuf for cross-service communication of the grammars so the compiler has the ability to produce these files too. I think this was experimented with and then discarded for some reason in favour of just using the tarball of JSON files directly in treelights.

I wasn't involved in this decision and I have no idea what the highlighter team's intentions are beyond "eventually move everything to treesitter" so I'm just going to keep the lights on for now.

@lildude lildude requested a review from a team as a code owner May 30, 2023 09:17
@lildude lildude merged commit fd79827 into master Sep 13, 2023
5 checks passed
@lildude lildude deleted the lildude/use-ghcr-io branch September 13, 2023 08:42
lildude added a commit that referenced this pull request Sep 13, 2023
lildude added a commit that referenced this pull request Sep 13, 2023
Revert "Use ghcr.io for grammar compiler docker container (#6322)"

This reverts commit fd79827.
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants