Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WDL's description #6319

Merged
merged 12 commits into from
Jun 5, 2023
Merged

Conversation

aofarrel
Copy link
Contributor

@aofarrel aofarrel commented Mar 13, 2023

  • Fix name to show Workflow Description Language rather than just wdl to put it in line with other languages (compare cwl/Common Workflow Language) See comments below. This does raise the question if CWL should be changed since it's usually called CWL in my experience, but I'll leave that to people more familiar with that language to make that call.
  • Add two interpreters
  • Moved it to maintain alphabetical ordering

WDL wasn't misclassified per say, so none of the checklists seem to apply?

* Fix name to show Workflow Description Language rather than just wdl (in line with cwl/Common Workflow Language)
* Add two interpreters
@aofarrel aofarrel requested a review from a team as a code owner March 13, 2023 22:51
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix name to show Workflow Description Language rather than just wdl to put it in line with other languages (compare cwl/Common Workflow Language)

Is this language really more commonly referred to as "Workflow Description Language" in full than the "wdl/WDL" acronym?

We try to use the most commonly use term/name for languages. For example we use XML, HTML, CSS etc... as these are more commonly referred to by their acronyms than their full names and from a quick look of https://openwdl.org/ even they seem to refer to it more as wdl/WDL... the big fat logo at the top of the page is even "wdl".

If we were to go with this change, you'll also need to rename the samples directory.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@aofarrel
Copy link
Contributor Author

Fix name to show Workflow Description Language rather than just wdl to put it in line with other languages (compare cwl/Common Workflow Language)

Is this language really more commonly referred to as "Workflow Description Language" in full than the "wdl/WDL" acronym?

This is a fair point! I was extrapolating from how this repo handles Common Workflow Language, usually shortened to CWL but showing as Common Workflow Language here. WDL is almost always referred to as WDL, so I'll revert that part.

Revert WDL back to its more common name
@aofarrel aofarrel requested a review from lildude March 15, 2023 21:16
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@aofarrel aofarrel requested review from Alhadis and removed request for lildude March 28, 2023 20:17
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're also going to need to address the test failures, namely changing the case of the directory that hold the samples and fixing the order in the README.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@lildude lildude requested a review from a team as a code owner May 30, 2023 09:32
aofarrel and others added 6 commits May 31, 2023 12:25
they're interpreters, but they're not used in shebangs, so they get cut

Co-authored-by: Colin Seymour <colin@github.com>
@lildude lildude enabled auto-merge June 5, 2023 10:14
@lildude lildude added this pull request to the merge queue Jun 5, 2023
Merged via the queue into github-linguist:master with commit a480ded Jun 5, 2023
5 checks passed
@aofarrel aofarrel deleted the update-wdl branch June 7, 2023 19:42
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants