Change colour for OCaml

[Teddy55Codes]

Changing the language color of OCaml.
I noticed that all Ocaml branding is orange (#ee6a1a) but the color shown on Github is green (#3be133).

Description

I think this change is justified for the following reasons:

• The color #3be133 was set back in 2012 in the "Colors!" commit.
• The logo and the official website is all orange specifically #ee6a1a.

I picked #ee6a1a because it is the accent color on the official website. I couldn't use to logo color due to it having a slight color gradient, but it is basically the same shade of orange.

If you want to vote or comment on this change you can do that on this poll

Checklist:

• I am changing the color associated with a language
  • [Ongoing poll] I have obtained agreement from the wider language community on this color change.
    • official website
    • poll
    • poll 2 (shade)

[Teddy55Codes]

Ok, so recognised a potential issue with my change. OCaml can be used in web development and html is also orange. Let me know if that is a problem and if a different shade with more contrast should be used or if the current green is fine.

[lildude]

• [~] I have obtained agreement from the wider language community on this color change.

Unfortunately, this is going to be a hard requirement here. People are passionate about their colours (see #4319) especially when things have been in place for over 10 years as is the case here.

Ok, so recognised a potential issue with my change. OCaml can be used in web development and html is also orange. Let me know if that is a problem and if a different shade with more contrast should be used or if the current green is fine.

Whilst similar and even identical colours are now accepted, this could be an additional cause for conflict.

[Teddy55Codes]

Thank you for your response. I will start seeking opinions from the OCaml community.

[lildude]

Please keep the colour discussions out of this issue. Any discussion of preference should take place in the official OCaml community discussion channels (the one that needs to be referenced in the OP) for the language in question, not this issue or repo.

(Updated to clarify where the discussions should take place).

[Teddy55Codes]

I have asked the OCaml community for there opinion. I have done this via 2 votes on the Discussion page of the official OCaml repository. I have found an overwhelming majority of the community agrees with this change. Both votes are mentioned in the "Checklist" section of my pull request.

[Teddy55Codes]

Hello, i don't want to seem inpatient but it has been almost 2 month since i have requested a review. I would really appreciate an answer.
@lildude

[lildude]

Hello, i don't want to seem inpatient but it has been almost 2 month since i have requested a review. I would really appreciate an answer.

There's no rush, this change which won't take effect until the next release 😄 (I review all PRs before each release).

The number of respondents seems really low for a wider community acceptance, but I'll leave that on you to defend if someone complains 😉 (I doubt this will given the choice is closer to actual branding, but you never know.)

[lildude]

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

[Teddy55Codes]

Thanks for the quick response. Also thank you for being so patient with me. I made a lot of mistakes that could have been avoided if i had just read the contribution guidelines. 👍