-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune Perl/Raku heuristics #6264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Relax Perl pattern: 'use 5;' and 'use v5;' are acceptable (no '.' required). - Treat 'use constant' and 'use overload' as Perl; Raku has different mechanisms for constants and operator overloading. - Treat assignments to @export as Perl (Raku has a different symbol export mechanism): our @export = (...) @export = (...) *EXPORT = [...] - Treat package declarations as Perl, not Raku: package Foo::Bar; package Foo::Bar v1.2.3; package Foo::Bar 1.05; package Foo::Bar { ... } - As a last resort, recognize the use of '->' for dereferencing and method calls as indicative of Perl (Raku uses '.' for methods and has no references): Some::Class->class_method $some_variable->method $Some::Class::variable->method $array_reference->[0] $hash_reference->{key} $code_reference->(@arguments)
This is to avoid test failures with samples/Raku/hash.t, which is 50% Raku code and 50% Perl code (embedded as a multi-line string in Raku). Without the negative 'use v6' pattern, the heuristics would detect the embedded code as Perl (which it is).
Alhadis
requested changes
Jan 26, 2023
Source: https://metacpan.org/release/RJBS/Color-Palette-0.100004/source/lib/Color/Palette/Schema.pm License is "perl_5", i.e. dual GPLv1 (or later) or Artistic 1.0: https://metacpan.org/release/RJBS/Color-Palette-0.100004/source/LICENSE
Alhadis
approved these changes
Jan 26, 2023
lildude
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6263.
Description
Relax Perl pattern:
use 5;
anduse v5;
are acceptable (no.
required).Treat
use constant
anduse overload
as Perl; Raku has different mechanisms for constants and operator overloading.Treat assignments to
@EXPORT
as Perl (Raku has a different symbol export mechanism):Treat package declarations as Perl, not Raku:
As a last resort, recognize the use of
->
for dereferencing and method calls as indicative of Perl (Raku uses.
for methods and has no references):Checklist