Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yuescript #6259

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

haroon26
Copy link

@haroon26 haroon26 commented Jan 22, 2023

Description

I have added a new language called 'yuescript'. This has been added from issue #6087 request.

Checklist:

Closes #6087

@haroon26 haroon26 requested a review from a team as a code owner January 22, 2023 16:51
@lildude lildude changed the title added yuescript Add Yuescript Jan 24, 2023
@haroon26
Copy link
Author

I will commit changes tonight to pass all the checks

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popularity isn't high enough for inclusion yet, but that doesn't mean you can't address the inline comment.

It's probably a good idea to add a colour too. Maybe #b7ae8f as used on the Yuescript website?

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@lildude
Copy link
Member

lildude commented Jul 10, 2024

Closing as the requested changes have not been made in well over a year since being requested. Please open a new PR when you have the time to make the requested changes.

@lildude lildude closed this Jul 10, 2024
@lildude lildude reopened this Jul 10, 2024
@lildude lildude requested a review from a team as a code owner July 10, 2024 09:00
@lildude
Copy link
Member

lildude commented Jul 10, 2024

Whoops. A little too eager on this one.

@lildude lildude dismissed their stale review July 10, 2024 09:01

Requested changed made. Pending popularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yuescript
2 participants