Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour for HCL #6231

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Add colour for HCL #6231

merged 2 commits into from
Feb 17, 2023

Conversation

tuunit
Copy link
Contributor

@tuunit tuunit commented Dec 29, 2022

Description

Default color for HCL as decided by the Hashicorp Team: hashicorp/hcl#577

Checklist:

@Alhadis
Copy link
Collaborator

Alhadis commented Dec 29, 2022

#ccc is simply the default colour GitHub assigns to languages that don't have one defined. If you intend to add a colour for HashiCorp Configuration Language (HCL), I'd suggest using one taken from HashiCorp's official branding instead.

@Alhadis Alhadis changed the title add GitHub color for HCL Add colour for HCL Dec 29, 2022
@tuunit
Copy link
Contributor Author

tuunit commented Dec 29, 2022

#ccc is simply the default colour GitHub assigns to languages that don't have one defined. If you intend to add a colour for HashiCorp Configuration Language (HCL), I'd suggest using one taken from HashiCorp's official branding instead.

As HashiCorp doesn't have a official color branding for HCL. I raised an issue regarding the color in the official HCL repository.

@tuunit
Copy link
Contributor Author

tuunit commented Jan 5, 2023

Hi @Alhadis, I got a reply from @crw (Technical Community Manager at Hashicorp) and they internally decided to use a purplish colour #844FBA.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@Alhadis
Copy link
Collaborator

Alhadis commented Jan 9, 2023

I got a reply from @crw (Technical Community Manager at Hashicorp) and they internally decided to use a purplish colour #844FBA.

Just for posterity, would you mind taking a screenshot of their response so that we have their response on record? (Feel free to blur out your e-mail address and/or name if you aren't comfortable making those details public)

@tuunit
Copy link
Contributor Author

tuunit commented Jan 9, 2023

Hi @Alhadis,

the response is part of the linked issue: hashicorp/hcl#577

@crw
https://www.linkedin.com/in/craigw/

image

@Alhadis
Copy link
Collaborator

Alhadis commented Jan 9, 2023

Perfect, that's exactly what I had in mind. 👍 Thanks!

@lildude lildude merged commit 11885ab into github-linguist:master Feb 17, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants