Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color for PlantUML. #6225

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Potherca
Copy link
Contributor

Description

This MR adds a color for PlantUML.

The color is the yellow from the official UML "cube" logo

Althought Unified Modeling Language, UML, and the UML Cube Logo are registered trademarks ® of the Object Management Group, Inc., the color bears no copyright.

The community at large was asked for their opinion through the normal channels of communication in July 2021 (both in a GitHub issue and on the user forum). There was little response.

The creator of PlantUML and a few contributors did respond, all opting for the "official" yellow (the yellow used in the PlantUML logo is 2% off, the consensus was to go with the "correct" color instead).

Checklist:

@Potherca Potherca requested a review from a team as a code owner December 22, 2022 18:34
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude merged commit ceb731e into github-linguist:master Feb 17, 2023
@Potherca Potherca deleted the plantuml/add-color branch February 17, 2023 13:22
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants