Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarification for override using alias + case-insensitive #6187

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Add clarification for override using alias + case-insensitive #6187

merged 3 commits into from
Nov 30, 2022

Conversation

DecimalTurn
Copy link
Contributor

I noticed that it was possible to use an alias of the language for overrides here, so thought it would be good to mention it in the docs.

@DecimalTurn DecimalTurn requested a review from a team as a code owner November 24, 2022 15:43
Alhadis
Alhadis requested changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well take this opportunity to point out that language names are matched case-insensitively as well.

docs/overrides.md Outdated Show resolved Hide resolved
@DecimalTurn DecimalTurn changed the title Add clarification for override using alias Add clarification for override using alias + case-insensitive Nov 24, 2022
Alhadis
Alhadis approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I personally would've opened the second sentence with Ergo instead of So (it's a bit more formal), but that's pretty much nitpicking at this point.

@lildude lildude merged commit c1c34e5 into github-linguist:master Nov 30, 2022
@DecimalTurn DecimalTurn deleted the patch-1 branch November 30, 2022 21:22
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

@Alhadis Alhadis Alhadis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DecimalTurn @lildude @Alhadis