Amend Just language entry

[casey]

Sorry for not catching this in the initial review!

• Remove Justfile alias. just is the name of the tool and the language.
• Just looks for files called justfile in any case, so add the three most common cases: JUSTFILE, Justfile, and justfile.
• Add the .just extension, which is in common use. See this search: https://github.com/search?q=extension%3Ajust

[mihaigalos]

@casey, what would you say if we refactor this to Justfile instead of just as file naming?
The way it currently shows up is this:

[mihaigalos]

Or capitalize the 1st letter?

[Alhadis]

Or capitalize the 1st letter?

Yes, that's supposed to be the language's human-readable name, not its file extension or interpreter. Note that exceptions are made for non-standard casing if that's how the language's name is canonically spelt (e.g., reStructuredText, mIRC Script, cURL Config, et al).

Remove Justfile alias. just is the name of the tool and the language.

Don't. This is a valid addition: it enables users to highlight Markdown code-blocks with ```justfile as well as ```just.

[mihaigalos]

@casey: Can you please allow others' contributions to this PR? I wanted to implement some of the suggestions but couldn't since it's read-only.

[casey]

@mihaigalos I think of the name of the language as being just, as in the just language, and not the justfile language. Doing a quick search on google, "the make language" seems to be more common than "the makefile language", so this is consistent with make. Although, I note that Makefile is used by linguist. Overall I prefer just, and capitalizing it seems to be the convention with linguist, so I changed it to Just.

Don't. This is a valid addition: it enables users to highlight Markdown code-blocks with justfile as well as just.

@Alhadis I'm not sure I see the value of adding an additional alias. Wouldn't it be better to have a single way of annotating markdown code blocks?

[Alhadis]

Wouldn't it be better to have a single way of annotating markdown code blocks?

No, because this is the same lookup machinery responsible for interpreting language: operators in code-searches, or the value of linguist-language= in a .gitattributes file. I think we can all agree that js and javascript should both be mapped to the same language entry. Likewise for Just.

Remember, users who type ```justfile in the middle of a long-winded comment won't always catch themselves writing the "wrong" name. Some might even fail to notice that their annotated code-block is missing highlighting altogether. We should strive for intuitive, "DWIM" behaviour instead of being needlessly restrictive.

[Alhadis]

@casey FYI, I pushed a fix to your branch that updated the capitalisation of the samples/just directory—something that's notoriously fiddly to do on a case-insensitive filesystem (so, macOS and Windows). The languages.yml list is also meant to be ordered case-sensitively, so I fixed that as well.

[casey]

@casey FYI, I pushed a fix to your branch that updated the capitalisation of the samples/just directory—something that's notoriously fiddly to do on a case-insensitive filesystem (so, macOS and Windows). The languages.yml list is also meant to be ordered case-sensitively, so I fixed that as well.

Thanks!

Remember, users who type ```justfile in the middle of a long-winded comment won't always catch themselves writing the "wrong" name. Some might even fail to notice that their annotated code-block is missing highlighting altogether. We should strive for intuitive, "DWIM" behaviour instead of being needlessly restrictive.

Fair enough! I added the alias back.

[Alhadis]

Ace. Well, this looks good to me. Now we just need to wait for @lildude to give the GitHub Staffer's Seal-of-Approval™ so we can merge this.

[lildude]

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

[lildude]

Don’t worry about merging in master. I’ll do it again before merging.