Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language support for Ecmarkup #6152

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Add language support for Ecmarkup #6152

merged 3 commits into from
Nov 12, 2022

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Oct 30, 2022

Description

This PR adds support for Ecmarkup, a superset of HTML used by TC39 for authoring language specifications and proposals. Since it's grouped under HTML, this addition is chiefly for the benefit of clearer highlighting.

Usage-wise, I'm actually not sure if it fulfils the criteria or not: Code Search reports ~1,700 results, but because this format is predominantly used by TC39, there's a good chance that 1,700 results fails to span 200 unique users. @lildude, make sure you assess popularity. 😉

Checklist:

  • I am adding a new language
    • The extension of the new language is used in hundreds of repositories
    • I have included a real-world usage sample.
    • I have updated the heuristics to distinguish my language from others using the same extension.

@Alhadis Alhadis marked this pull request as ready for review October 30, 2022 19:01
@Alhadis Alhadis requested a review from a team as a code owner October 30, 2022 19:01
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks popular enough when we exclude tc39 from a cursory glance.

@Alhadis Alhadis merged commit 72a59d0 into master Nov 12, 2022
@Alhadis Alhadis deleted the ecmarkup branch November 12, 2022 14:30
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants