Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .all-contributorsrc as JSON #6137

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Add .all-contributorsrc as JSON #6137

merged 4 commits into from
Oct 26, 2022

Conversation

spenserblack
Copy link
Contributor

@spenserblack spenserblack commented Oct 25, 2022

This adds .all-contributorsrc as JSON. Link to documentation describing this file as JSON

Checklist:

@spenserblack spenserblack changed the title [DRAFT] Add .all-contributorsrc as JSON Add .all-contributorsrc as JSON Oct 26, 2022
@spenserblack spenserblack marked this pull request as ready for review October 26, 2022 03:27
@spenserblack spenserblack requested a review from a team as a code owner October 26, 2022 03:27
Comment on lines +8 to +19
"contributors": [
{
"login": "kentcdodds",
"name": "Kent C. Dodds",
"avatar_url": "https://github.com/avatars/u/1500684?v=3",
"profile": "https://kentcdodds.com",
"contributions": [
"question",
"doc",
"review",
"talk"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can trim the contributors array down to only a few entries. The entries are mostly homogenous, so our classifier isn't really benefiting from the repetition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for the quick response! I was a little unsure about this because, while certainly real-world, it did feel overboard. So would you say about 3 would be enough?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, 3's plenty. 👍

@Alhadis
Copy link
Collaborator

Alhadis commented Oct 26, 2022

@lildude Usage checks out. Code search reports ~6,200 results; pretty damn sure there's at least 200 different users among those results.

@Alhadis Alhadis merged commit 9198a24 into github-linguist:master Oct 26, 2022
@spenserblack spenserblack deleted the language/json/all-contributorsrc branch October 26, 2022 14:27
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants