Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pdm.lock to TOML and mark as generated #6133

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2022

This pull request adds support for recognizing the lock file of PDM, a Python package manager.

Checklist:

  • I am associating a language with a new file extension.
    • The new extension is used in hundreds of repositories on GitHub.com
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s): generated myself with pdm add requests pyyaml to match the Pipfile
      • Sample license(s): CC0 I guess, not claiming any copyright on it if a machine-generated lock file is even copyrightable
    • I have included a change to the heuristics to distinguish my language from others using the same extension. not applicable since this is a full filename, no known clashes
  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

@ghost ghost self-requested a review as a code owner October 24, 2022 13:13
@lildude
Copy link
Member

lildude commented Oct 26, 2022

You've used the wrong section of the template. Please update the OP and fill in the "I am associating a language with a new file extension." section. We especially need to know where the samples come from and the license of each for legal reasons.

@lildude lildude changed the title Add pdm.lock Add pdm.lock to TOML and mark as generated Oct 26, 2022
@ghost
Copy link
Author

ghost commented Oct 26, 2022

Fair enough, I thought this was fine because of this comment:

  <!-- This includes modifying the vendor, documentation, and generated lists. -->

but I guess my PR is kinda a two in one.

I've updated the OP, let me know if it's preferable to take a pdm.lock from an existing project instead of self-generated.

@lildude
Copy link
Member

lildude commented Oct 26, 2022

I've updated the OP, let me know if it's preferable to take a pdm.lock from an existing project instead of self-generated.

Perfect 👌

The only thing to do now is sort out the order so the tests pass.

@lildude lildude merged commit ece5f4f into github-linguist:master Nov 14, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants