Add WORKSPACE.bazel to Starlark filenames #6127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lildude
requested changes
Oct 18, 2022
Both WORKSPACE and WORKSPACE.bazel are valid names for the WORKSPACE file. The latter takes precedent, even though it is an alias because other projects may have a similarly named file. Alternatively, *.bazel could be added to extensions, but .bzl is the recommended extension. This adds a WORKSPACE.bazel file from https://github.com/google/skia/blob/main/WORKSPACE.bazel
Alphadelta14
force-pushed
the
workspace-bazel
branch
from
c2f745d
to
38c7bd1
Compare
lildude
changed the title
lildude
approved these changes
Oct 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WORKSPACE.bazel as another Starklark matching case.
Description
Both WORKSPACE and WORKSPACE.bazel are valid names for the WORKSPACE file. The latter takes precedent, even though it is an alias because other projects may have a similarly named file.
Alternatively, *.bazel could be added to extensions, but .bzl is the recommended extension.
Checklist: