-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OASv2 and OASv3 languages #6116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
The ghes-3.4.*
samples are also massive. Please replace these with much smaller samples (ProTip: it the diff collapses them, they're too big 😉).
I have implemented all requested changes. |
https://github.com/github/linguist/blob/master/docs/overrides.md#detectable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed you've not added tests specifically for your new heuristics for matching the OAS files. Please add these.
@lildude Yes, just added them + rebase from master for f-f merging. Thanks ! |
Description
Add OASv2 and OASv3 disambiguation as heuristics for JSON and YAML (see #6115)
Checklist: