Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDC and XDC to TCL language #6094

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Add SDC and XDC to TCL language #6094

merged 4 commits into from
Oct 20, 2022

Conversation

nishtahir
Copy link
Contributor

@nishtahir nishtahir commented Sep 28, 2022

Closes #6092

Description

This adds Synopsis and Xilinx design constraint files as TCL files for syntax highlighting and linguist reporting purposes. I'm not 100% sure if this was everything that needs to be done to support this. I'd appreciate any feedback/guidance anyone may have.

Checklist:

@nishtahir nishtahir requested a review from a team as a code owner September 28, 2022 14:06
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if this was everything that needs to be done to support this.

We have a whole section in the CONTRIBUTING.md file dedicated to this. Read it, you'll see what you're missing 😉 .

Please also update the template in the OP.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Show resolved Hide resolved
@lildude
Copy link
Member

lildude commented Sep 28, 2022

You can ignore the CI failure for now. It'll be resolved once #6093 has been merged.

@juj
Copy link

juj commented Sep 29, 2022

@nishtahir thanks for creating a PR on this!

@lildude lildude merged commit bea5c73 into github-linguist:master Oct 20, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .sdc (Synopsys Design Constrants) to TCL
3 participants