-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brewfile to bootstrap #6068
Conversation
Add Brewfile Call brew bundle from script/bootstrap gitignore homebrew lockfile
IMHO, this isn't any more convenient than simply copying the |
This conforms to "scripts to rule them all", which is still very much a standard at GitHub and with various GitHub open source projects. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Colin Seymour <colin@github.com>
I have added a
Brewfile
and invokedbrew bundle
inside the app'sscript/bootstrap
as a convenience to other developers.Description
While cloning linguist to develop against it, I noticed that it lacks a
Brewfile
and an invocation ofbrew bundle
in thescript/bootstrap
file, which would alleviate the need for manually installing all of the dependencies. I have added this to better automate and document the dependencies. I have also added a test for whether the user is running on macOS to the potential invocation of this new functionality.Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language