Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brewfile to bootstrap #6068

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Conversation

bval
Copy link
Contributor

@bval bval commented Sep 14, 2022

I have added a Brewfile and invoked brew bundle inside the app's script/bootstrap as a convenience to other developers.

Description

While cloning linguist to develop against it, I noticed that it lacks a Brewfile and an invocation of brew bundle in the script/bootstrap file, which would alleviate the need for manually installing all of the dependencies. I have added this to better automate and document the dependencies. I have also added a test for whether the user is running on macOS to the potential invocation of this new functionality.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

    • Old: [URL to grammar repo]
    • New: [URL to grammar repo]
  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@bval bval requested a review from a team as a code owner September 14, 2022 16:26
@Alhadis
Copy link
Collaborator

Alhadis commented Sep 14, 2022

IMHO, this isn't any more convenient than simply copying the brew install commands from CONTRIBUTING.md and pasting them into the terminal. If anything, it's adding needless complexity to a step that contributors are only expected to run once.

@rick
Copy link
Contributor

rick commented Sep 15, 2022

This conforms to "scripts to rule them all", which is still very much a standard at GitHub and with various GitHub open source projects. 👍

Copy link
Contributor

@rick rick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship this automation

ship this automation

README.md Outdated Show resolved Hide resolved
Co-authored-by: Colin Seymour <colin@github.com>
README.md Outdated Show resolved Hide resolved
@bval bval merged commit 12cfef6 into github-linguist:master Sep 16, 2022
@bval bval deleted the add-brewfile-to-bootstrap branch September 16, 2022 17:44
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants