Adjust Go generated detection #6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't as concise as it could be or as the current spec suggests, but that's deliberate as we need to still detect uses of the old obsolete format.
Alhadis
approved these changes
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #5026, the current Go generated detection is a little too liberal as it finds cases of the string generation tools add to the generated files.
This PR addresses that by making the detection a little more concise, but not not as concise as it could be or as the current spec suggests. This is deliberate as we need to still detect uses of the old obsolete format and it's not Linguist's responsibility to call out users of old tools.
Fixes #5026