Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypher Query Language #6027

Merged
merged 15 commits into from
Oct 20, 2022
Merged

Add Cypher Query Language #6027

merged 15 commits into from
Oct 20, 2022

Conversation

007vasy
Copy link
Contributor

@007vasy 007vasy commented Aug 21, 2022

All tests are ok

Desciption

This PR adds the Cypher query language with the *.cypher and *.cyp extension.

*.cql is removed because:

The language is a graph query language https://opencypher.org/ and it's ISO recognition is WIP

regarding cypher extension There are already:

  • 12k code results
  • 411k package results
  • 915k topic results

regarding cyp extension There are already:

  • 1.4k code results
  • 382k package results
  • 895k topic results

So It would be great to have syntax highlighting on github (and later search as well) :)

Godspeed!

Checklist:

* add cypher grammar
* add samples
* add missing file extension sample
* upd ordering
* add extra sample
* making license type precise
@007vasy 007vasy requested a review from a team as a code owner August 21, 2022 23:20
@007vasy
Copy link
Contributor Author

007vasy commented Aug 21, 2022

@lildude fixed the tests:
All tests are ok

@007vasy
Copy link
Contributor Author

007vasy commented Aug 25, 2022

@lildude I want to make you proud!

@lildude lildude changed the title Add Cypher Query Language syntax highlighting and file extension detection Add Cypher Query Language Sep 2, 2022
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the .cql and .cyp files with real-world usage samples.

I recommend adding at least two real world highly representative samples for the .cql extension as this extension is already used by SQL and good representative samples will help the classifier make a better guess.

@007vasy
Copy link
Contributor Author

007vasy commented Sep 4, 2022

@lildude done

@lildude
Copy link
Member

lildude commented Sep 5, 2022

Wow! We don't need that many samples - two per extension is plenty. We also don't want duplicate content with different extensions as that doesn't train the classifier to differentiate between the extensions.

@007vasy
Copy link
Contributor Author

007vasy commented Sep 5, 2022

the thing is with Cypher that all 3 extension can be used, it does not matter which is used so think from the training point of view it's good to have similar content with different extensions to help the classifier

@lildude
Copy link
Member

lildude commented Sep 6, 2022

the thing is with Cypher that all 3 extension can be used

In that case we only need one unique and most representative sample per extension, except for .cql due to it already being in use. Three identical copies of seven files is excessive and adds no value.

* more samples

* trim examples
@007vasy
Copy link
Contributor Author

007vasy commented Sep 6, 2022

@lildude done, left more examples for .cql and 1-1 for .cyp and .cyhper

@lildude
Copy link
Member

lildude commented Sep 7, 2022

Thanks. Please update the OP to point to the original source for each file and their relevant license.

I'll check the extensions meet our popularity requirements closer to merge time.

@007vasy
Copy link
Contributor Author

007vasy commented Sep 7, 2022

@lildude

  • updated OP
  • added licenses
  • removed one example

If you check the search results, it is going over by a mile to the popularity reqs

@007vasy 007vasy requested a review from lildude September 8, 2022 01:25
@007vasy
Copy link
Contributor Author

007vasy commented Sep 8, 2022

and thank you for your patience!

@adriens
Copy link

adriens commented Sep 10, 2022

➕ 1️⃣ 🗳️ 🙏

@adriens
Copy link

adriens commented Sep 10, 2022

cf community/community#32466

@007vasy
Copy link
Contributor Author

007vasy commented Sep 15, 2022

@lildude is there anything else needed?

@007vasy
Copy link
Contributor Author

007vasy commented Sep 20, 2022

hi @lildude, @Alhadis what is the release schedule?

007vasy and others added 2 commits September 21, 2022 09:32
* Update languages.yml

* remove cql

* typo

* new examples

Co-authored-by: benf <benf@local>
@lildude
Copy link
Member

lildude commented Sep 21, 2022

hi @lildude, @Alhadis what is the release schedule?

There isn't one. I make an release when I've got the time somewhere close to the next release of GitHub Enterprise Server as it's not a quick process. I'm also holding off approving PRs which add new languages until I'm close to release as it takes a lot more time to review than simple fixes.

"Be patient my young Padawan".

@adriens
Copy link

adriens commented Sep 21, 2022

"Be patient my young Padawan".

AWESOME 🤣

@007vasy
Copy link
Contributor Author

007vasy commented Sep 24, 2022

thanks for the update!

Copy link

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG 😮 You mean it will be availbale soon on GH ? When should I start to give it a try ❔

@007vasy
Copy link
Contributor Author

007vasy commented Oct 3, 2022

the most probable point in time in the next github enterprise release, which could happen next week or 3 months from now

based on the github enterprise release schedule this could happen late october early november, best case

@adriens
Copy link

adriens commented Oct 3, 2022

So let's 🤞 🐱

@007vasy
Copy link
Contributor Author

007vasy commented Oct 9, 2022

@lildude can you at least allow the tests to run?

it should be fine I tested them on my fork, but I don't want to miss an other release window if possible

@adriens
Copy link

adriens commented Oct 9, 2022

🤞 🙏 💯

@adriens
Copy link

adriens commented Oct 19, 2022

Ready to 🚀 ❔

@lildude
Copy link
Member

lildude commented Oct 19, 2022

Yes, but it won't appear on GitHub until I make a release.

@lildude lildude merged commit b51aa7a into github-linguist:master Oct 20, 2022
@007vasy
Copy link
Contributor Author

007vasy commented Nov 14, 2022

@lildude do you have an estimate for a github release?

@lildude
Copy link
Member

lildude commented Nov 15, 2022

#6162

@adriens
Copy link

adriens commented Nov 17, 2022

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants