-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypher Query Language #6027
Conversation
* add cypher grammar * add samples * add missing file extension sample * upd ordering * add extra sample * making license type precise
@lildude fixed the tests: |
@lildude I want to make you proud! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the .cql
and .cyp
files with real-world usage samples.
I recommend adding at least two real world highly representative samples for the .cql
extension as this extension is already used by SQL and good representative samples will help the classifier make a better guess.
@lildude done |
Wow! We don't need that many samples - two per extension is plenty. We also don't want duplicate content with different extensions as that doesn't train the classifier to differentiate between the extensions. |
the thing is with Cypher that all 3 extension can be used, it does not matter which is used so think from the training point of view it's good to have similar content with different extensions to help the classifier |
In that case we only need one unique and most representative sample per extension, except for |
* more samples * trim examples
* trim examples
@lildude done, left more examples for |
Thanks. Please update the OP to point to the original source for each file and their relevant license. I'll check the extensions meet our popularity requirements closer to merge time. |
If you check the search results, it is going over by a mile to the popularity reqs |
and thank you for your patience! |
➕ 1️⃣ 🗳️ 🙏 |
@lildude is there anything else needed? |
* Update languages.yml * remove cql * typo * new examples Co-authored-by: benf <benf@local>
There isn't one. I make an release when I've got the time somewhere close to the next release of GitHub Enterprise Server as it's not a quick process. I'm also holding off approving PRs which add new languages until I'm close to release as it takes a lot more time to review than simple fixes. "Be patient my young Padawan". |
AWESOME 🤣 |
thanks for the update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG 😮 You mean it will be availbale soon on GH ? When should I start to give it a try ❔
the most probable point in time in the next github enterprise release, which could happen next week or 3 months from now based on the github enterprise release schedule this could happen late october early november, best case |
So let's 🤞 🐱 |
@lildude can you at least allow the tests to run? it should be fine I tested them on my fork, but I don't want to miss an other release window if possible |
🤞 🙏 💯 |
Ready to 🚀 ❔ |
Yes, but it won't appear on GitHub until I make a release. |
@lildude do you have an estimate for a github release? |
All tests are ok
Desciption
This PR adds the Cypher query language with the
*.cypher
and*.cyp
extension.*.cql
is removed because:The language is a graph query language https://opencypher.org/ and it's ISO recognition is WIP
regarding
cypher
extension There are already:regarding
cyp
extension There are already:So It would be great to have syntax highlighting on github (and later search as well) :)
Godspeed!
Checklist:
graphgems.*
db_export_res.cypher
:load_from_json.cypher
: