Update Ace mode paths for tests #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory structure was changed in ajaxorg/ace#4851
|
There doesn't appear to be any rationale behind ajaxorg/ace#4851. If upstream makes this sort of change willy-nilly, then it might be wiser to query the latest tagged release, as opposed to HEAD. Doing so will reduce the risk of this happening again, since there's no guarantee such an arbitrary change won't be reverted later. |
There is now as I asked for one 😁. Based on this, I think we're good to stay with using HEAD. This has been the first major change like this since we implemented the test so I think we should be good querying both locations for the future. |
lildude
changed the title
Alhadis
approved these changes
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream directory structure was changed in ajaxorg/ace#4851 which means we're looking in the wrong place for all the languages supported by the Ace editor. We now need to look in the old location for
jsoniqandxqueryand the new location for everything else.These changes have been made as they plan to release Ace as an NPM.