Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .kql as extension for KQL (Kusto Query Language) #5995

Merged
merged 5 commits into from
Sep 2, 2022

Conversation

ep3p
Copy link
Contributor

@ep3p ep3p commented Jul 26, 2022

Description

Please, this was already considered in #4827 . I think currently .kql is widely used over .csl

I would like to open another PR to change the grammar (or I will commit in this PR if you help me please), I would like to add this grammar (although it is outdated)
https://github.com/rosshamish/kuskus/blob/7aa46fd48ebf50c9cbfb98c06782a5e9d86dc535/kusto-syntax-highlighting/syntaxes/kusto.tmLanguage

The only "problem" is that this repo has several extensions apart from syntax highlighting, please, do you know if as long as the engine finds the kusto.tmLanguage file is enough?

Checklist:

@ep3p ep3p requested a review from a team as a code owner July 26, 2022 18:54
@lildude
Copy link
Member

lildude commented Jul 27, 2022

I would like to open another PR to change the grammar (or I will commit in this PR if you help me please), I would like to add this grammar (although it is outdated) https://github.com/rosshamish/kuskus/blob/7aa46fd48ebf50c9cbfb98c06782a5e9d86dc535/kusto-syntax-highlighting/syntaxes/kusto.tmLanguage

I'd prefer a new PR so it can easily be reverted independent of other changes if necessary.

The only "problem" is that this repo has several extensions apart from syntax highlighting, please, do you know if as long as the engine finds the kusto.tmLanguage file is enough?

Generally yes, however the location of the grammar files is important as the compiler only looks in certain locations depending on the expected location for the upstream editor that uses the grammars:

https://github.com/github/linguist/blob/249bbd1c2ffc631ca2ec628da26be5800eec3d48/tools/grammars/compiler/loader.go#L119-L128

I've taken a quick look at the repo and you should be ok. It's not go too much other cruft and the grammar should be easily found. Give it a try 😁.

@lildude
Copy link
Member

lildude commented Jul 27, 2022

Please, this was already considered in #4827 . I think currently .kql is widely used over .csl

Yup. Usage looks to have grown quite considerably since then. 👍

@ep3p
Copy link
Contributor Author

ep3p commented Jul 27, 2022

Thank you @lildude I have opened another PR for the grammar change (#5996)

@lildude lildude merged commit e43977c into github-linguist:master Sep 2, 2022
@ep3p ep3p deleted the patch-1 branch September 6, 2022 08:49
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants