Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Elvish #5940

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Add support for Elvish #5940

merged 2 commits into from
Sep 2, 2022

Conversation

xiaq
Copy link
Contributor

@xiaq xiaq commented Jun 13, 2022

Usage in the wild:
https://github.com/search?q=extension%3Aelv&type=Code&ref=advsearch&l=&l=. There
are a couple of false positives, but the vast majority of the results are Elvish
scripts.

Code sample is taken from Elvish's standard library:
https://github.com/elves/elvish/blob/master/pkg/mods/epm/epm.elv, license BSD
2-clause.

Description

Checklist:

@xiaq xiaq requested a review from a team as a code owner June 13, 2022 23:00
Usage in the wild:
https://github.com/search?q=extension%3Aelv&type=Code&ref=advsearch&l=&l=. There
are a couple of false positives, but the vast majority of the results are Elvish
scripts.

Code sample is taken from Elvish's standard library:
https://github.com/elves/elvish/blob/master/pkg/mods/epm/epm.elv, license BSD
2-clause.
@xiaq
Copy link
Contributor Author

xiaq commented Jun 14, 2022

@lildude Hi! Thanks for taking a look, I see you added the "Pending Popularity" which I assume means that the new language may not meet the popularity threshold.

Since the documented criterion is at least 200 unique repos, I wrote a program to test whether Elvish clears that criterion. The result is 224 repos as of today.

There are some false positives - not all .elv files are Elvish scripts. Clicking these repos randomly, roughly 1 or 2 out of every 10 repos are false positives. So the actual number of repos may be just a bit lower than 200.

Do you think this is close enough to the threshold, or should I try again the number of unique repos is clearly larger than 200?

@lildude
Copy link
Member

lildude commented Jun 14, 2022

We're temporarily using the requirements detailed in #5756 because GitHub's search is struggling with extension searches which often results in inaccurate, zero or duplicate results.

@xiaq
Copy link
Contributor Author

xiaq commented Jun 14, 2022

I see, thanks. The number of results for .elv currently stands at 1794, hopefully it will be over 2000 soon :)

Maybe it's valuable to link to that issue from CONTRIBUTING.md - I opened #5941 for this.

@lildude lildude changed the title Add support for Elvish (https://elv.sh). Add support for Elvish Jun 27, 2022
@lildude lildude merged commit 1dde1b4 into github-linguist:master Sep 2, 2022
@xiaq xiaq mentioned this pull request Mar 1, 2023
5 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants