-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Pact smart contract language #5834
Conversation
I support this request as the Kadena blockchain continues to scale its operations to the masses! |
Can you please check this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add samples for the .repl ext or remove it from this PR.
As an aside, usage is still too low to be accepted right now.
@lildude updated with .repl sample script. Has the popularity window for support been shifted? It would seem like we have enough content for support at this point. |
@itsthejoker is there a problem you'd like to vocalize? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage has indeed improved from a quick glance so we might be good to go when it comes to merging.
Co-authored-by: Colin Seymour <colin@github.com>
@lildude Addressed your comments. Anything else you need from me? |
Ping! |
Pong! 🏓 "Patience, my young Padawan". The speed of review isn't going to change the rate at which this PR will be merged as PRs are only merged close to making releases. |
Looks good now but the language is still too low in popularity. I'll review this again around each release and will only approve the PR once the popularity requirement has been met. |
Alright, thanks for the update on policy so i can stop pinging 😅. We'll see if we can get more people to publish their work openly. |
Concerns have now been addressed. Now we wait for popularity to increase.
We've had quite a bit of dev work come online recently. Have we met the bar yet @lildude? |
This PR adds an entry for the Pact smart contract language.
Description
Following the directions in
CONTRIBUTORS.md
, this PR adds:Checklist:
NB: we have many private clients that do not open source their code, but store their scripts on private enterprise github accounts, outnumbering the number of representative public samples.
I have included a real-world usage sample for all extensions added in this PR:
Sample source(s):
Sample license(s):
I have included a syntax highlighting grammar: https://github.com/kadena-io/pact-atom/blob/master/grammars/pact.cson
I have updated the heuristics to distinguish my language from others using the same extension.