Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Pact smart contract language #5834

Merged
merged 8 commits into from
May 30, 2023

Conversation

emilypi
Copy link
Contributor

@emilypi emilypi commented Mar 22, 2022

This PR adds an entry for the Pact smart contract language.

Description

Following the directions in CONTRIBUTORS.md, this PR adds:

  • A language entry for Pact
  • An EBNF specification for Pact
  • Sample scripts used in real world applications
  • Sample licenses used in real world scripts

Checklist:

NB: we have many private clients that do not open source their code, but store their scripts on private enterprise github accounts, outnumbering the number of representative public samples.

@emilypi emilypi requested a review from a team as a code owner March 22, 2022 23:53
@MrMrManatee
Copy link

I support this request as the Kadena blockchain continues to scale its operations to the masses!

@yasinsil
Copy link

Can you please check this ?

lib/linguist/languages.yml Outdated Show resolved Hide resolved
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add samples for the .repl ext or remove it from this PR.

As an aside, usage is still too low to be accepted right now.

@emilypi
Copy link
Contributor Author

emilypi commented Feb 6, 2023

@lildude updated with .repl sample script. Has the popularity window for support been shifted? It would seem like we have enough content for support at this point.

@emilypi
Copy link
Contributor Author

emilypi commented Feb 6, 2023

@itsthejoker is there a problem you'd like to vocalize?

lildude
lildude previously requested changes Feb 7, 2023
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage has indeed improved from a quick glance so we might be good to go when it comes to merging.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@emilypi
Copy link
Contributor Author

emilypi commented Feb 7, 2023

@lildude Addressed your comments. Anything else you need from me?

@emilypi emilypi requested a review from lildude February 10, 2023 18:39
@emilypi
Copy link
Contributor Author

emilypi commented Feb 13, 2023

Ping!

@lildude
Copy link
Member

lildude commented Feb 14, 2023

Pong! 🏓

"Patience, my young Padawan". The speed of review isn't going to change the rate at which this PR will be merged as PRs are only merged close to making releases.

@lildude
Copy link
Member

lildude commented Feb 14, 2023

Looks good now but the language is still too low in popularity. I'll review this again around each release and will only approve the PR once the popularity requirement has been met.

@emilypi
Copy link
Contributor Author

emilypi commented Feb 14, 2023

Alright, thanks for the update on policy so i can stop pinging 😅. We'll see if we can get more people to publish their work openly.

@lildude lildude dismissed their stale review February 17, 2023 10:28

Concerns have now been addressed. Now we wait for popularity to increase.

@emilypi
Copy link
Contributor Author

emilypi commented May 4, 2023

We've had quite a bit of dev work come online recently. Have we met the bar yet @lildude?

@lildude lildude requested a review from a team as a code owner May 30, 2023 10:09
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit 8a2415b May 30, 2023
5 checks passed
@emilypi emilypi deleted the add-pact-language branch June 1, 2023 16:05
@XoL1507

This comment was marked as spam.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants